drinkingtea/nostalgia
drinkingtea/nostalgia
2
0
Fork 0
Code Issues 6 Pull Requests Actions Releases 6 Activity

[olympic] Cleanup ItemMaker, remove unnecessary copy
All checks were successful
Build / build (push) Successful in 2m22s
Details

Browse Source
This commit is contained in:
Gary Talent 2024-04-21 10:32:42 -05:00
parent ebf3a6961e
commit 84205879d4
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/olympic/studio/modlib/include/studio/itemmaker.hpp
View File

@ -19,7 +19,9 @@ class ItemMaker {
ox::String const parentDir; ox::String const parentDir;
ox::String const fileExt; ox::String const fileExt;
constexpr explicit ItemMaker( constexpr explicit ItemMaker(
ox::StringView pName, ox::StringView pParentDir, ox::CRStringView pFileExt) noexcept: ox::StringView pName,
ox::StringView pParentDir,
ox::StringView pFileExt) noexcept:
typeName(pName), typeName(pName),
parentDir(pParentDir), parentDir(pParentDir),
fileExt(pFileExt) { fileExt(pFileExt) {
@ -62,7 +64,7 @@ class ItemMakerT: public ItemMaker {
T pItem, T pItem,
ox::ClawFormat pFmt) noexcept: ox::ClawFormat pFmt) noexcept:
ItemMaker(pDisplayName, pParentDir, fileExt), ItemMaker(pDisplayName, pParentDir, fileExt),
m_item(pItem), m_item(std::move(pItem)),
m_fmt(pFmt) { m_fmt(pFmt) {
} }
constexpr ItemMakerT( constexpr ItemMakerT(