From 84205879d46610dfe08098d1265c0398f2215d3d Mon Sep 17 00:00:00 2001
From: Gary Talent <gary@drinkingtea.net>
Date: Sun, 21 Apr 2024 10:32:42 -0500
Subject: [PATCH] [olympic] Cleanup ItemMaker, remove unnecessary copy

---
 src/olympic/studio/modlib/include/studio/itemmaker.hpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/olympic/studio/modlib/include/studio/itemmaker.hpp b/src/olympic/studio/modlib/include/studio/itemmaker.hpp
index 1f7bf10d..ee095a79 100644
--- a/src/olympic/studio/modlib/include/studio/itemmaker.hpp
+++ b/src/olympic/studio/modlib/include/studio/itemmaker.hpp
@@ -19,7 +19,9 @@ class ItemMaker {
 		ox::String const parentDir;
 		ox::String const fileExt;
 		constexpr explicit ItemMaker(
-				ox::StringView pName, ox::StringView pParentDir, ox::CRStringView pFileExt) noexcept:
+				ox::StringView pName,
+				ox::StringView pParentDir,
+				ox::StringView pFileExt) noexcept:
 			typeName(pName),
 			parentDir(pParentDir),
 			fileExt(pFileExt) {
@@ -62,7 +64,7 @@ class ItemMakerT: public ItemMaker {
 				T pItem,
 				ox::ClawFormat pFmt) noexcept:
 			ItemMaker(pDisplayName, pParentDir, fileExt),
-			m_item(pItem),
+			m_item(std::move(pItem)),
 			m_fmt(pFmt) {
 		}
 		constexpr ItemMakerT(