From baf5fa3199fc2625af05393ddd5d0eaffedf5770 Mon Sep 17 00:00:00 2001 From: Gary Talent Date: Sat, 21 Jun 2025 08:54:57 -0500 Subject: [PATCH 1/3] [nostalgia] Move d2025.05.2 release notes to d2025.06.0 --- release-notes.md | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/release-notes.md b/release-notes.md index f3888fb1d..da5058533 100644 --- a/release-notes.md +++ b/release-notes.md @@ -5,18 +5,17 @@ * Fix file deletion to close file even if not active * Fix file copy to work when creating a copy with the name of a previously deleted file -* Fix copy/cut/paste enablement when there is no selection * Make file picker popup accept on double click of a file +* TileSheetEditor: Fix copy/cut/paste enablement when there is no selection +* TileSheetEditor: Fix manual redo of draw actions, fix drawing to pixel 0, 0 + as first action +* TileSheetEditor: Fix draw command to work on same pixel after switching + subsheets * PaletteEditor: Add RGB key shortcuts for focusing color channels * PaletteEditor: Add color preview to color editor * PaletteEditor: Make RGB key shortcuts work when color channel inputs are focused -# d2025.05.2 - -* TileSheetEditor: Fix manual redo of draw actions, fix drawing to pixel 0, 0 as first action (cce5f52f96511694afd98f0b9b6b1f19c06ecd20) -* TileSheetEditor: Fix draw command to work on same pixel after switching subsheets (514cb978351ee4b0a5335c22a506a6d9f608f0a7) - # d2025.05.1 * TileSheetEditor: Fix overrun errors when switching subsheets, clear selection From 0efed70b57dd3300189c366527699c3313cb2660 Mon Sep 17 00:00:00 2001 From: Gary Talent Date: Sat, 21 Jun 2025 14:11:34 -0500 Subject: [PATCH 2/3] [studio] Fix Studio to clear editor pointers when opening a new project --- release-notes.md | 1 + src/olympic/studio/applib/src/studioui.cpp | 3 +++ 2 files changed, 4 insertions(+) diff --git a/release-notes.md b/release-notes.md index da5058533..b0f8ebd51 100644 --- a/release-notes.md +++ b/release-notes.md @@ -5,6 +5,7 @@ * Fix file deletion to close file even if not active * Fix file copy to work when creating a copy with the name of a previously deleted file +* Fix crash that could occur after switching projects * Make file picker popup accept on double click of a file * TileSheetEditor: Fix copy/cut/paste enablement when there is no selection * TileSheetEditor: Fix manual redo of draw actions, fix drawing to pixel 0, 0 diff --git a/src/olympic/studio/applib/src/studioui.cpp b/src/olympic/studio/applib/src/studioui.cpp index 51acc2402..99babadf3 100644 --- a/src/olympic/studio/applib/src/studioui.cpp +++ b/src/olympic/studio/applib/src/studioui.cpp @@ -649,6 +649,9 @@ ox::Error StudioUI::openProjectPath(ox::StringParam path) noexcept { ox::make_unique_catch(keelCtx(m_tctx), std::move(path), m_projectDataDir) .moveTo(m_project)); m_sctx.project = m_project.get(); + m_activeEditor = nullptr; + m_activeEditorOnLastDraw = nullptr; + m_activeEditorUpdatePending = nullptr; turbine::setWindowTitle( m_tctx, ox::sfmt("{} - {}", keelCtx(m_tctx).appName, m_project->projectPath())); m_deleteConfirmation.deleteFile.connect(m_sctx.project, &Project::deleteItem); From 37cfa927d1d63390d91a6c4b98021023552dd980 Mon Sep 17 00:00:00 2001 From: Gary Talent Date: Sat, 21 Jun 2025 09:33:52 -0500 Subject: [PATCH 3/3] [nostalgia/gfx] Address a couple of implicit conversions --- .../src/studio/tilesheeteditor/commands/addsubsheetcommand.cpp | 2 +- .../gfx/src/studio/tilesheeteditor/tilesheeteditor-imgui.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/nostalgia/modules/gfx/src/studio/tilesheeteditor/commands/addsubsheetcommand.cpp b/src/nostalgia/modules/gfx/src/studio/tilesheeteditor/commands/addsubsheetcommand.cpp index d9d3a7404..ba35b3922 100644 --- a/src/nostalgia/modules/gfx/src/studio/tilesheeteditor/commands/addsubsheetcommand.cpp +++ b/src/nostalgia/modules/gfx/src/studio/tilesheeteditor/commands/addsubsheetcommand.cpp @@ -13,7 +13,7 @@ AddSubSheetCommand::AddSubSheetCommand( auto &parent = getSubSheet(m_img, m_parentIdx); if (!parent.subsheets.empty()) { auto idx = m_parentIdx; - idx.emplace_back(parent.subsheets.size()); + idx.emplace_back(static_cast(parent.subsheets.size())); m_addedSheets.push_back(idx); } else { auto idx = m_parentIdx; diff --git a/src/nostalgia/modules/gfx/src/studio/tilesheeteditor/tilesheeteditor-imgui.cpp b/src/nostalgia/modules/gfx/src/studio/tilesheeteditor/tilesheeteditor-imgui.cpp index ba53777c9..aee2a5811 100644 --- a/src/nostalgia/modules/gfx/src/studio/tilesheeteditor/tilesheeteditor-imgui.cpp +++ b/src/nostalgia/modules/gfx/src/studio/tilesheeteditor/tilesheeteditor-imgui.cpp @@ -278,7 +278,7 @@ void TileSheetEditorImGui::draw(studio::Context&) noexcept { auto insertOnIdx = m_model.activeSubSheetIdx(); auto const &parent = m_model.activeSubSheet(); m_model.addSubsheet(insertOnIdx); - insertOnIdx.emplace_back(parent.subsheets.size() - 1); + insertOnIdx.emplace_back(static_cast(parent.subsheets.size() - 1)); setActiveSubsheet(insertOnIdx); } ImGui::SameLine();