drinkingtea/nostalgia
2
0
Fork 0
Code Issues 4 Pull Requests Actions Releases 13 Activity

[nostalgia,studio] Remove implicit ox::String::String(const char*) calls

Browse Source
This commit is contained in:
Gary Talent
2023-12-01 22:35:02 -06:00
parent 644abd7f22
commit e9822bf124
7 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/studio/applib/src/newmenu.cpp
View File

@@ -12,7 +12,7 @@
namespace studio {
NewMenu::NewMenu() noexcept {
setTitle("New Item");
setTitle(ox::String("New Item"));
setSize({225, 110});
}

2
src/studio/applib/src/newmenu.hpp
View File

@@ -23,7 +23,7 @@ class NewMenu: public studio::Popup {
};
// emits path parameter
ox::Signal<ox::Error(const ox::String&)> finished;
ox::Signal<ox::Error(ox::StringView)> finished;
private:
Stage m_stage = Stage::Closed;

4
src/studio/applib/src/projectexplorer.cpp
View File

@@ -11,10 +11,10 @@
namespace studio {
static ox::Result<ox::UniquePtr<ProjectTreeModel>>
buildProjectTreeModel(ProjectExplorer *explorer, ox::String name, ox::CRStringView path, ProjectTreeModel *parent) noexcept {
buildProjectTreeModel(ProjectExplorer *explorer, ox::StringView name, ox::CRStringView path, ProjectTreeModel *parent) noexcept {
const auto fs = explorer->romFs();
oxRequire(stat, fs->stat(path));
auto out = ox::make_unique<ProjectTreeModel>(explorer, name, parent);
auto out = ox::make_unique<ProjectTreeModel>(explorer, ox::String(name), parent);
if (stat.fileType == ox::FileType::Directory) {
oxRequireM(children, fs->ls(path));
std::sort(children.begin(), children.end());