diff --git a/src/nostalgia/modules/core/src/keel/keelmodule.cpp b/src/nostalgia/modules/core/src/keel/keelmodule.cpp index 96b2d4f1..57dd9036 100644 --- a/src/nostalgia/modules/core/src/keel/keelmodule.cpp +++ b/src/nostalgia/modules/core/src/keel/keelmodule.cpp @@ -60,7 +60,7 @@ class KeelModule: public keel::Module { typeId == ox::buildTypeId() || typeId == ox::buildTypeId()) { oxReturnError(keel::convertBuffToBuff( - ctx, buff, ox::ClawFormat::Metal).moveTo(&buff)); + ctx, buff, ox::ClawFormat::Metal).moveTo(buff)); } return {}; }, diff --git a/src/nostalgia/modules/core/src/opengl/gfx.cpp b/src/nostalgia/modules/core/src/opengl/gfx.cpp index 42efa873..1d2bbcb7 100644 --- a/src/nostalgia/modules/core/src/opengl/gfx.cpp +++ b/src/nostalgia/modules/core/src/opengl/gfx.cpp @@ -364,9 +364,9 @@ ox::Error initGfx( const auto bgFshad = ox::sfmt(renderer::bgfshadTmpl, gl::GlslVersion); const auto spriteVshad = ox::sfmt(renderer::spritevshadTmpl, gl::GlslVersion); const auto spriteFshad = ox::sfmt(renderer::spritefshadTmpl, gl::GlslVersion); - oxReturnError(glutils::buildShaderProgram(bgVshad, bgFshad).moveTo(&ctx.bgShader)); + oxReturnError(glutils::buildShaderProgram(bgVshad, bgFshad).moveTo(ctx.bgShader)); oxReturnError( - glutils::buildShaderProgram(spriteVshad, spriteFshad).moveTo(&ctx.spriteShader)); + glutils::buildShaderProgram(spriteVshad, spriteFshad).moveTo(ctx.spriteShader)); for (auto &bg : ctx.cbbs) { initBackgroundBufferset(ctx.bgShader, bg); } diff --git a/src/nostalgia/modules/core/src/studio/tilesheeteditor/tilesheeteditormodel.cpp b/src/nostalgia/modules/core/src/studio/tilesheeteditor/tilesheeteditormodel.cpp index 6a47e5bc..b0f4d8e7 100644 --- a/src/nostalgia/modules/core/src/studio/tilesheeteditor/tilesheeteditormodel.cpp +++ b/src/nostalgia/modules/core/src/studio/tilesheeteditor/tilesheeteditormodel.cpp @@ -217,7 +217,7 @@ ox::Error TileSheetEditorModel::markUpdatedCmdId(const studio::UndoCommand *cmd) m_updated = true; const auto cmdId = cmd->commandId(); if (static_cast(cmdId) == CommandId::PaletteChange) { - oxReturnError(readObj(keelCtx(m_ctx), m_img.defaultPalette).moveTo(&m_pal)); + oxReturnError(readObj(keelCtx(m_ctx), m_img.defaultPalette).moveTo(m_pal)); paletteChanged.emit(); } auto tsCmd = dynamic_cast(cmd); diff --git a/src/nostalgia/modules/core/src/studio/tilesheeteditor/tilesheetpixelgrid.cpp b/src/nostalgia/modules/core/src/studio/tilesheeteditor/tilesheetpixelgrid.cpp index 14596609..832cc815 100644 --- a/src/nostalgia/modules/core/src/studio/tilesheeteditor/tilesheetpixelgrid.cpp +++ b/src/nostalgia/modules/core/src/studio/tilesheeteditor/tilesheetpixelgrid.cpp @@ -18,7 +18,7 @@ ox::Error TileSheetGrid::buildShader() noexcept { const auto pixelLineVshad = ox::sfmt(VShad, gl::GlslVersion); const auto pixelLineFshad = ox::sfmt(FShad, gl::GlslVersion); const auto pixelLineGshad = ox::sfmt(GShad, gl::GlslVersion); - return glutils::buildShaderProgram(pixelLineVshad, pixelLineFshad, pixelLineGshad).moveTo(&m_shader); + return glutils::buildShaderProgram(pixelLineVshad, pixelLineFshad, pixelLineGshad).moveTo(m_shader); } void TileSheetGrid::draw(bool update, ox::Vec2 const&scroll) noexcept { diff --git a/src/nostalgia/modules/core/src/studio/tilesheeteditor/tilesheetpixels.cpp b/src/nostalgia/modules/core/src/studio/tilesheeteditor/tilesheetpixels.cpp index 6a537471..079a1e9f 100644 --- a/src/nostalgia/modules/core/src/studio/tilesheeteditor/tilesheetpixels.cpp +++ b/src/nostalgia/modules/core/src/studio/tilesheeteditor/tilesheetpixels.cpp @@ -19,7 +19,7 @@ void TileSheetPixels::setPixelSizeMod(float sm) noexcept { ox::Error TileSheetPixels::buildShader() noexcept { const auto Vshad = ox::sfmt(VShad, gl::GlslVersion); const auto Fshad = ox::sfmt(FShad, gl::GlslVersion); - return glutils::buildShaderProgram(Vshad, Fshad).moveTo(&m_shader); + return glutils::buildShaderProgram(Vshad, Fshad).moveTo(m_shader); } void TileSheetPixels::draw(bool update, ox::Vec2 const&scroll) noexcept { diff --git a/src/olympic/keel/include/keel/media.hpp b/src/olympic/keel/include/keel/media.hpp index 378ed49d..1d3c6d4a 100644 --- a/src/olympic/keel/include/keel/media.hpp +++ b/src/olympic/keel/include/keel/media.hpp @@ -67,7 +67,7 @@ ox::Result> readObjFile( if (err) { oxRequire(buff, ctx.rom->read(path)); oxRequire(obj, readConvert(ctx, buff)); - oxReturnError(ctx.assetManager.setAsset(assetId, obj).moveTo(&cached)); + oxReturnError(ctx.assetManager.setAsset(assetId, obj).moveTo(cached)); } return cached; } diff --git a/src/olympic/keel/include/keel/pack.hpp b/src/olympic/keel/include/keel/pack.hpp index 66209ba4..85dc5a1c 100644 --- a/src/olympic/keel/include/keel/pack.hpp +++ b/src/olympic/keel/include/keel/pack.hpp @@ -98,10 +98,10 @@ ox::Error preloadObj( oxReturnError(pl.endAlloc()); oxReturnError(err); const keel::PreloadPtr p{.preloadAddr = static_cast(a)}; - oxReturnError(ox::writeMC(p).moveTo(&buff)); + oxReturnError(ox::writeMC(p).moveTo(buff)); } else { // strip the Claw header (it is not needed after preloading) and write back out to dest fs - oxReturnError(ox::writeMC(obj).moveTo(&buff)); + oxReturnError(ox::writeMC(obj).moveTo(buff)); } oxReturnError(romFs.write(path, buff.data(), buff.size())); return {}; diff --git a/src/olympic/keel/include/keel/typeconv.hpp b/src/olympic/keel/include/keel/typeconv.hpp index 3f2d1485..9c6e3e9a 100644 --- a/src/olympic/keel/include/keel/typeconv.hpp +++ b/src/olympic/keel/include/keel/typeconv.hpp @@ -183,7 +183,7 @@ auto transformRule(keel::Context &ctx, ox::Buffer &buff) noexcept -> ox::Error { const auto typeId = ox::buildTypeId( hdr.clawHdr.typeName, hdr.clawHdr.typeVersion, hdr.clawHdr.typeParams); if (typeId == ox::buildTypeId()) { - oxReturnError(keel::convertBuffToBuff(ctx, buff, fmt).moveTo(&buff)); + oxReturnError(keel::convertBuffToBuff(ctx, buff, fmt).moveTo(buff)); } return {}; }; diff --git a/src/olympic/keel/src/asset.cpp b/src/olympic/keel/src/asset.cpp index c318ebde..dad82a19 100644 --- a/src/olympic/keel/src/asset.cpp +++ b/src/olympic/keel/src/asset.cpp @@ -31,11 +31,11 @@ ox::Result readAsset(ox::TypeStore *ts, ox::Buffer const&buff) ox::Result readAssetHeader(const char *buff, std::size_t buffLen) noexcept { AssetHdr out; - const auto err = readUuidHeader(buff, buffLen).moveTo(&out.uuid); + const auto err = readUuidHeader(buff, buffLen).moveTo(out.uuid); const auto offset = err ? 0u : K1HdrSz; buff = buff + offset; buffLen = buffLen - offset; - oxReturnError(ox::readClawHeader(buff, buffLen).moveTo(&out.clawHdr)); + oxReturnError(ox::readClawHeader(buff, buffLen).moveTo(out.clawHdr)); return out; } diff --git a/src/olympic/keel/src/pack.cpp b/src/olympic/keel/src/pack.cpp index f6627d7d..04b1eb66 100644 --- a/src/olympic/keel/src/pack.cpp +++ b/src/olympic/keel/src/pack.cpp @@ -30,7 +30,7 @@ static ox::Error pathToInode( } if (beginsWith(path, "uuid://")) { const auto uuid = substr(path, 7); - oxReturnError(keel::uuidToPath(ctx, uuid).moveTo(&path)); + oxReturnError(keel::uuidToPath(ctx, uuid).moveTo(path)); } oxRequire(s, dest.stat(path)); oxReturnError(o["type"].set(static_cast(ox::FileAddressType::Inode))); @@ -97,7 +97,7 @@ static ox::Error doTransformations( // transform FileAddresses oxRequireM(obj, keel::readAsset(&ts, buff)); oxReturnError(transformFileAddressesObj(ctx, dest, obj)); - oxReturnError(ox::writeClaw(obj).moveTo(&buff)); + oxReturnError(ox::writeClaw(obj).moveTo(buff)); // write file to dest oxReturnError(dest.write(s.inode, buff)); return {}; diff --git a/src/olympic/studio/applib/src/studioapp.cpp b/src/olympic/studio/applib/src/studioapp.cpp index 6cc75a10..331e2d5b 100644 --- a/src/olympic/studio/applib/src/studioapp.cpp +++ b/src/olympic/studio/applib/src/studioapp.cpp @@ -257,7 +257,7 @@ void StudioUI::drawTabs() noexcept { m_activeEditor = nullptr; } try { - oxThrowError(m_editors.erase(it).moveTo(&it)); + oxThrowError(m_editors.erase(it).moveTo(it)); } catch (const ox::Exception &ex) { oxErrf("Editor tab deletion failed: {} ({}:{})\n", ex.what(), ex.file, ex.line); } catch (const std::exception &ex) { @@ -363,7 +363,7 @@ ox::Error StudioUI::openFileActiveTab(ox::CRStringView path, bool makeActiveTab) } editor = ox::make(path, std::move(obj)); } else { - const auto err = m_editorMakers[ext](path).moveTo(&editor); + const auto err = m_editorMakers[ext](path).moveTo(editor); if (err) { if constexpr(!ox::defines::Debug) { oxErrf("Could not open Editor: {}\n", toStr(err)); diff --git a/src/olympic/turbine/src/gba/turbine.cpp b/src/olympic/turbine/src/gba/turbine.cpp index 860f9de2..113861d9 100644 --- a/src/olympic/turbine/src/gba/turbine.cpp +++ b/src/olympic/turbine/src/gba/turbine.cpp @@ -60,7 +60,7 @@ ox::Result init( auto ctx = ox::make_unique(); oxReturnError(keel::init(ctx->keelCtx, std::move(fs), appName)); #ifdef OX_BARE_METAL - oxReturnError(findPreloadSection().moveTo(&ctx->keelCtx.preloadSectionOffset)); + oxReturnError(findPreloadSection().moveTo(ctx->keelCtx.preloadSectionOffset)); #endif oxReturnError(initGfx(*ctx)); initTimer();