From a0c645f25c09607fd6e5494126e67917ff695369 Mon Sep 17 00:00:00 2001
From: Gary Talent <gary@drinkingtea.net>
Date: Tue, 11 May 2021 22:08:33 -0500
Subject: [PATCH] [ox/fs] Replace some reinterpret_casts with placement-new

---
 deps/ox/src/ox/fs/filesystem/directory.hpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/deps/ox/src/ox/fs/filesystem/directory.hpp b/deps/ox/src/ox/fs/filesystem/directory.hpp
index 7d82a0ff..6acd9e13 100644
--- a/deps/ox/src/ox/fs/filesystem/directory.hpp
+++ b/deps/ox/src/ox/fs/filesystem/directory.hpp
@@ -150,7 +150,7 @@ Error Directory<FileStore, InodeId_t>::mkdir(PathIterator path, bool parents, Fi
 		oxTrace("ox::fs::Directory::mkdir") << path.fullPath();
 		// reuse nameBuff if it has already been allocated, as it is a rather large variable
 		if (nameBuff == nullptr) {
-			nameBuff = reinterpret_cast<FileName*>(ox_alloca(sizeof(FileName)));
+			nameBuff = new (ox_alloca(sizeof(FileName))) FileName;
 		}
 
 		// determine if already exists
@@ -193,7 +193,7 @@ template<typename FileStore, typename InodeId_t>
 Error Directory<FileStore, InodeId_t>::write(PathIterator path, InodeId_t inode, FileName *nameBuff) noexcept {
 	// reuse nameBuff if it has already been allocated, as it is a rather large variable
 	if (nameBuff == nullptr) {
-		nameBuff = reinterpret_cast<FileName*>(ox_alloca(sizeof(FileName)));
+		nameBuff = new (ox_alloca(sizeof(FileName))) FileName;
 	}
 	auto name = nameBuff;
 
@@ -261,7 +261,7 @@ template<typename FileStore, typename InodeId_t>
 Error Directory<FileStore, InodeId_t>::remove(PathIterator path, FileName *nameBuff) noexcept {
 	// reuse nameBuff if it has already been allocated, as it is a rather large variable
 	if (nameBuff == nullptr) {
-		nameBuff = reinterpret_cast<FileName*>(ox_alloca(sizeof(FileName)));
+		nameBuff = new (ox_alloca(sizeof(FileName))) FileName;
 	}
 	auto &name = *nameBuff;
 	oxReturnError(path.get(&name));
@@ -339,7 +339,7 @@ template<typename FileStore, typename InodeId_t>
 Result<typename FileStore::InodeId_t> Directory<FileStore, InodeId_t>::find(PathIterator path, FileName *nameBuff) const noexcept {
 	// reuse nameBuff if it has already been allocated, as it is a rather large variable
 	if (nameBuff == nullptr) {
-		nameBuff = reinterpret_cast<FileName*>(ox_alloca(sizeof(FileName)));
+		nameBuff = new (ox_alloca(sizeof(FileName))) FileName;
 	}
 
 	// determine if already exists