From 8c6b2234ecdaa8ce90c4268843421d233842bd11 Mon Sep 17 00:00:00 2001 From: Gary Talent Date: Mon, 5 May 2025 23:11:37 -0500 Subject: [PATCH] [olympic/util] Make pkg-gba script check return code of subprocesses --- util/scripts/pkg-gba.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/util/scripts/pkg-gba.py b/util/scripts/pkg-gba.py index 10f069b6..98dfc995 100755 --- a/util/scripts/pkg-gba.py +++ b/util/scripts/pkg-gba.py @@ -17,6 +17,10 @@ os = platform.system().lower() arch = platform.machine() host_env = f'{os}-{arch}' +def run(args: list[str]): + if subprocess.run(args).returncode != 0: + sys.exit(1) + # get current build type with open(".current_build", "r") as f: current_build = f.readlines()[0] @@ -31,9 +35,9 @@ project_gba = f'{project_name}.gba' project_manifest = f'{project_name.lower()}-manifest.json' shutil.copyfile(project_bin, project_gba) -subprocess.run([ +run([ f'{bin}/{project_name.lower()}-pack', '-src', project_dir, '-rom-bin', project_gba, '-manifest', project_manifest]) -subprocess.run(['gbafix', project_gba]) +run(['gbafix', project_gba])