[ox] Address CLion warnings

deps/ox/src/ox/std/assert.cpp

@@ -7,11 +7,9 @@
  */
 
 #if defined(OX_USE_STDLIB)
-#include <bitset>
 #include <iostream>
 #endif
 
-#include "defines.hpp"
 #include "stacktrace.hpp"
 #include "trace.hpp"
 

deps/ox/src/ox/std/random.hpp

@@ -22,7 +22,7 @@ class OX_PACKED Random {
 	public:
 		Random();
 
-		Random(RandomSeed seed);
+		explicit Random(RandomSeed seed);
 
 		uint64_t gen();
 };

deps/ox/src/ox/std/string.cpp

@@ -177,7 +177,7 @@ std::size_t String::len() const noexcept {
 }
 
 std::size_t String::bytes() const noexcept {
-	std::size_t i = 0;
+	std::size_t i;
 	for (i = 0; i < m_buff.size() && m_buff[i]; i++);
 	return i + 1; // add one for null terminator
 }

deps/ox/src/ox/std/test/tests.cpp

@@ -25,25 +25,25 @@ std::map<std::string, std::function<int()>> tests = {
 	{
 		"ABCDEFG != HIJKLMN",
 		[]() {
-			return !(ox_memcmp("ABCDEFG", "HIJKLMN", 7) < 0);
+			return ox_memcmp("ABCDEFG", "HIJKLMN", 7) >= 0;
 		}
 	},
 	{
 		"HIJKLMN != ABCDEFG",
 		[]() {
-			return !(ox_memcmp("HIJKLMN", "ABCDEFG", 7) > 0);
+			return ox_memcmp("HIJKLMN", "ABCDEFG", 7) <= 0;
 		}
 	},
 	{
 		"ABCDEFG == ABCDEFG",
 		[]() {
-			return !(ox_memcmp("ABCDEFG", "ABCDEFG", 7) == 0);
+			return ox_memcmp("ABCDEFG", "ABCDEFG", 7) != 0;
 		}
 	},
 	{
 		"ABCDEFGHI == ABCDEFG",
 		[]() {
-			return !(ox_memcmp("ABCDEFGHI", "ABCDEFG", 7) == 0);
+			return ox_memcmp("ABCDEFGHI", "ABCDEFG", 7) != 0;
 		}
 	},
 	{

deps/ox/src/ox/std/trace.cpp

@@ -9,7 +9,6 @@
 #if defined(OX_USE_STDLIB)
 #include <iomanip>
 #include <iostream>
-#include <stdio.h>
 #endif
 
 #include "trace.hpp"