From 5f4e6740cca232f3abbe4da7e6960e2268681c7f Mon Sep 17 00:00:00 2001 From: Gary Talent Date: Sat, 7 Nov 2020 17:59:36 -0600 Subject: [PATCH] [nostalgia] Fix MSVC build --- src/nostalgia/core/CMakeLists.txt | 4 +++- src/nostalgia/core/studio/CMakeLists.txt | 4 +++- src/nostalgia/core/userland/CMakeLists.txt | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/nostalgia/core/CMakeLists.txt b/src/nostalgia/core/CMakeLists.txt index 78a6d2ad..66ba3817 100644 --- a/src/nostalgia/core/CMakeLists.txt +++ b/src/nostalgia/core/CMakeLists.txt @@ -4,7 +4,9 @@ add_library( media.cpp ) -target_compile_options(NostalgiaCore PUBLIC -Wsign-conversion) +if(NOT MSVC) + target_compile_options(NostalgiaCore PUBLIC -Wsign-conversion) +endif() target_link_libraries( NostalgiaCore PUBLIC diff --git a/src/nostalgia/core/studio/CMakeLists.txt b/src/nostalgia/core/studio/CMakeLists.txt index a3967b0f..b4727682 100644 --- a/src/nostalgia/core/studio/CMakeLists.txt +++ b/src/nostalgia/core/studio/CMakeLists.txt @@ -11,7 +11,9 @@ add_library( rsrc.qrc ) -target_compile_options(NostalgiaCore-Studio PRIVATE -Wsign-conversion) +if(NOT MSVC) + target_compile_options(NostalgiaCore-Studio PRIVATE -Wsign-conversion) +endif() target_link_libraries( NostalgiaCore-Studio diff --git a/src/nostalgia/core/userland/CMakeLists.txt b/src/nostalgia/core/userland/CMakeLists.txt index 8c559fdc..33ba3bf6 100644 --- a/src/nostalgia/core/userland/CMakeLists.txt +++ b/src/nostalgia/core/userland/CMakeLists.txt @@ -3,7 +3,9 @@ add_library( media.cpp ) -target_compile_options(NostalgiaCore-Userspace PRIVATE -Wsign-conversion) +if(NOT MSVC) + target_compile_options(NostalgiaCore-Userspace PRIVATE -Wsign-conversion) +endif() target_link_libraries( NostalgiaCore-Userspace PUBLIC