diff --git a/src/nostalgia/modules/gfx/src/gfx-gba.cpp b/src/nostalgia/modules/gfx/src/gfx-gba.cpp index 169933d3..d264c024 100644 --- a/src/nostalgia/modules/gfx/src/gfx-gba.cpp +++ b/src/nostalgia/modules/gfx/src/gfx-gba.cpp @@ -350,7 +350,7 @@ void panic(const char *file, int line, const char *panicMsg, ox::Error const&err const auto heapEnd = reinterpret_cast(MEM_EWRAM_BEGIN + heapSz); ox::heapmgr::initHeap(heapBegin, heapEnd); OX_ALLOW_UNSAFE_BUFFERS_END - auto tctx = turbine::init(keel::loadRomFs("").unwrap(), "Nostalgia").unwrap(); + auto tctx = turbine::init(keel::loadRomFs("").unwrap(), "Nostalgia").unwrap(); auto ctx = init(*tctx).unwrap(); std::ignore = initGfx(); std::ignore = initConsole(*ctx); diff --git a/src/nostalgia/modules/gfx/src/studio/tilesheeteditor/tilesheeteditormodel.cpp b/src/nostalgia/modules/gfx/src/studio/tilesheeteditor/tilesheeteditormodel.cpp index 5f4f99ad..7ff98b84 100644 --- a/src/nostalgia/modules/gfx/src/studio/tilesheeteditor/tilesheeteditormodel.cpp +++ b/src/nostalgia/modules/gfx/src/studio/tilesheeteditor/tilesheeteditormodel.cpp @@ -126,7 +126,7 @@ void TileSheetEditorModel::paste() { auto const pt1 = m_selection->a; auto const pt2 = ox::Point{s.columns * TileWidth, s.rows * TileHeight}; if (auto const cmd = ox::makeCatch( - CommandId::Paste, m_img, m_activeSubsSheetIdx, pt1, pt2, *cb); cmd.ok()) { + CommandId::Paste, m_img, m_activeSubsSheetIdx, pt1, pt2, *cb); cmd.value) { std::ignore = pushCommand(cmd.value); } } @@ -202,38 +202,38 @@ void TileSheetEditorModel::endDrawCommand() noexcept { } } -void TileSheetEditorModel::addSubsheet(TileSheet::SubSheetIdx const&parentIdx) noexcept { +void TileSheetEditorModel::addSubsheet(TileSheet::SubSheetIdx const &parentIdx) noexcept { std::ignore = pushCommand(ox::make(m_img, parentIdx)); } -void TileSheetEditorModel::rmSubsheet(TileSheet::SubSheetIdx const&idx) noexcept { +void TileSheetEditorModel::rmSubsheet(TileSheet::SubSheetIdx const &idx) noexcept { std::ignore = pushCommand(ox::make(m_img, idx)); } void TileSheetEditorModel::insertTiles( - TileSheet::SubSheetIdx const&idx, std::size_t const tileIdx, std::size_t const tileCnt) noexcept { + TileSheet::SubSheetIdx const &idx, std::size_t const tileIdx, std::size_t const tileCnt) noexcept { std::ignore = pushCommand(ox::make(m_img, idx, tileIdx, tileCnt)); } void TileSheetEditorModel::deleteTiles( - TileSheet::SubSheetIdx const&idx, std::size_t const tileIdx, std::size_t const tileCnt) noexcept { + TileSheet::SubSheetIdx const &idx, std::size_t const tileIdx, std::size_t const tileCnt) noexcept { std::ignore = pushCommand(ox::make(m_img, idx, tileIdx, tileCnt)); } ox::Error TileSheetEditorModel::updateSubsheet( - TileSheet::SubSheetIdx const&idx, ox::StringViewCR name, int const cols, int const rows) noexcept { + TileSheet::SubSheetIdx const &idx, ox::StringViewCR name, int const cols, int const rows) noexcept { OX_REQUIRE(cmd, ox::makeCatch(m_img, idx, name, cols, rows)); std::ignore = pushCommand(cmd); return {}; } -void TileSheetEditorModel::setActiveSubsheet(TileSheet::SubSheetIdx const&idx) noexcept { +void TileSheetEditorModel::setActiveSubsheet(TileSheet::SubSheetIdx const &idx) noexcept { m_activeSubsSheetIdx = idx; this->activeSubsheetChanged.emit(m_activeSubsSheetIdx); clearSelection(); } -void TileSheetEditorModel::fill(ox::Point const&pt, int const palIdx) noexcept { +void TileSheetEditorModel::fill(ox::Point const &pt, uint8_t const palIdx) noexcept { auto const&activeSubSheet = getSubSheet(m_img, m_activeSubsSheetIdx); // build idx list if (pt.x >= activeSubSheet.columns * TileWidth || pt.y >= activeSubSheet.rows * TileHeight) { @@ -280,7 +280,7 @@ ox::Error TileSheetEditorModel::rotateRight() noexcept { m_img, m_activeSubsSheetIdx, pt1, pt2, RotateCommand::Direction::Right)); } -void TileSheetEditorModel::setSelection(studio::Selection const&sel) noexcept { +void TileSheetEditorModel::setSelection(studio::Selection const &sel) noexcept { auto const &ss = activeSubSheet(); if (sel.a.x < ss.columns * TileWidth && sel.a.y < ss.rows * TileHeight) { m_selection.emplace(sel); @@ -291,7 +291,7 @@ void TileSheetEditorModel::setSelection(studio::Selection const&sel) noexcept { m_updated = true; } -void TileSheetEditorModel::select(ox::Point const&pt) noexcept { +void TileSheetEditorModel::select(ox::Point const &pt) noexcept { if (m_selTracker.updateCursorPoint(pt)) { setSelection(m_selTracker.selection()); } @@ -318,7 +318,7 @@ bool TileSheetEditorModel::updated() const noexcept { return m_updated; } -ox::Error TileSheetEditorModel::markUpdatedCmdId(studio::UndoCommand const*cmd) noexcept { +ox::Error TileSheetEditorModel::markUpdatedCmdId(studio::UndoCommand const *cmd) noexcept { m_updated = true; auto const cmdId = cmd->commandId(); if (static_cast(cmdId) == CommandId::PaletteChange) { @@ -394,9 +394,9 @@ ox::Error TileSheetEditorModel::moveSubSheet(TileSheet::SubSheetIdx src, TileShe void TileSheetEditorModel::getFillPixels( TileSheet::SubSheet const&activeSubSheet, - ox::Span pixels, - ox::Point const&pt, - int const oldColor) const noexcept { + ox::Span const pixels, + ox::Point const &pt, + uint8_t const oldColor) noexcept { auto const idx = ptToIdx(pt, activeSubSheet.columns); auto const relIdx = idx % PixelsPerTile; if (pixels[relIdx] || activeSubSheet.pixels[idx] != oldColor) { diff --git a/src/nostalgia/modules/gfx/src/studio/tilesheeteditor/tilesheeteditormodel.hpp b/src/nostalgia/modules/gfx/src/studio/tilesheeteditor/tilesheeteditormodel.hpp index 4f6945da..fae64016 100644 --- a/src/nostalgia/modules/gfx/src/studio/tilesheeteditor/tilesheeteditormodel.hpp +++ b/src/nostalgia/modules/gfx/src/studio/tilesheeteditor/tilesheeteditormodel.hpp @@ -14,7 +14,7 @@ namespace nostalgia::gfx { -class TileSheetEditorModel: public ox::SignalHandler { +class TileSheetEditorModel final: public ox::SignalHandler { public: ox::Signal activeSubsheetChanged; @@ -53,13 +53,13 @@ class TileSheetEditorModel: public ox::SignalHandler { bool acceptsClipboardPayload() const noexcept; [[nodiscard]] - constexpr TileSheet const&img() const noexcept; + constexpr TileSheet const &img() const noexcept; [[nodiscard]] constexpr TileSheet &img() noexcept; [[nodiscard]] - constexpr Palette const&pal() const noexcept; + constexpr Palette const &pal() const noexcept; [[nodiscard]] ox::String const &palPath() const & noexcept; @@ -71,26 +71,26 @@ class TileSheetEditorModel: public ox::SignalHandler { [[nodiscard]] size_t palettePage() const noexcept; - void drawCommand(ox::Point const&pt, std::size_t palIdx) noexcept; + void drawCommand(ox::Point const &pt, std::size_t palIdx) noexcept; - void drawLineCommand(ox::Point const&pt, std::size_t palIdx) noexcept; + void drawLineCommand(ox::Point const &pt, std::size_t palIdx) noexcept; void endDrawCommand() noexcept; - void addSubsheet(TileSheet::SubSheetIdx const&parentIdx) noexcept; + void addSubsheet(TileSheet::SubSheetIdx const &parentIdx) noexcept; - void rmSubsheet(TileSheet::SubSheetIdx const&idx) noexcept; + void rmSubsheet(TileSheet::SubSheetIdx const &idx) noexcept; - void insertTiles(TileSheet::SubSheetIdx const&idx, std::size_t tileIdx, std::size_t tileCnt) noexcept; + void insertTiles(TileSheet::SubSheetIdx const &idx, std::size_t tileIdx, std::size_t tileCnt) noexcept; - void deleteTiles(TileSheet::SubSheetIdx const&idx, std::size_t tileIdx, std::size_t tileCnt) noexcept; + void deleteTiles(TileSheet::SubSheetIdx const &idx, std::size_t tileIdx, std::size_t tileCnt) noexcept; - ox::Error updateSubsheet(TileSheet::SubSheetIdx const&idx, ox::StringView const&name, int cols, int rows) noexcept; + ox::Error updateSubsheet(TileSheet::SubSheetIdx const &idx, ox::StringView const &name, int cols, int rows) noexcept; - void setActiveSubsheet(TileSheet::SubSheetIdx const&) noexcept; + void setActiveSubsheet(TileSheet::SubSheetIdx const &) noexcept; [[nodiscard]] - TileSheet::SubSheet const&activeSubSheet() const noexcept { + TileSheet::SubSheet const &activeSubSheet() const noexcept { return getSubSheet(m_img, m_activeSubsSheetIdx); } @@ -100,19 +100,19 @@ class TileSheetEditorModel: public ox::SignalHandler { } [[nodiscard]] - constexpr TileSheet::SubSheetIdx const&activeSubSheetIdx() const noexcept { + constexpr TileSheet::SubSheetIdx const &activeSubSheetIdx() const noexcept { return m_activeSubsSheetIdx; } - void fill(ox::Point const&pt, int palIdx) noexcept; + void fill(ox::Point const &pt, uint8_t palIdx) noexcept; ox::Error rotateLeft() noexcept; ox::Error rotateRight() noexcept; - void setSelection(studio::Selection const&sel) noexcept; + void setSelection(studio::Selection const &sel) noexcept; - void select(ox::Point const&pt) noexcept; + void select(ox::Point const &pt) noexcept; void completeSelection() noexcept; @@ -121,7 +121,7 @@ class TileSheetEditorModel: public ox::SignalHandler { [[nodiscard]] bool updated() const noexcept; - ox::Error markUpdatedCmdId(studio::UndoCommand const*cmd) noexcept; + ox::Error markUpdatedCmdId(studio::UndoCommand const *cmd) noexcept; ox::Error markUpdated() noexcept; @@ -144,21 +144,21 @@ class TileSheetEditorModel: public ox::SignalHandler { ox::Error moveSubSheet(TileSheet::SubSheetIdx src, TileSheet::SubSheetIdx dst) noexcept; private: - void getFillPixels( - TileSheet::SubSheet const&activeSubSheet, + static void getFillPixels( + TileSheet::SubSheet const &activeSubSheet, ox::Span pixels, - ox::Point const&pt, - int oldColor) const noexcept; + ox::Point const &pt, + uint8_t oldColor) noexcept; void setPalPath() noexcept; ox::Error pushCommand(studio::UndoCommand *cmd) noexcept; - ox::Error handleFileRename(ox::StringViewCR, ox::StringViewCR newPath, ox::UUID const&id) noexcept; + ox::Error handleFileRename(ox::StringViewCR, ox::StringViewCR newPath, ox::UUID const &id) noexcept; }; -constexpr TileSheet const&TileSheetEditorModel::img() const noexcept { +constexpr TileSheet const &TileSheetEditorModel::img() const noexcept { return m_img; } @@ -166,7 +166,7 @@ constexpr TileSheet &TileSheetEditorModel::img() noexcept { return m_img; } -constexpr Palette const&TileSheetEditorModel::pal() const noexcept { +constexpr Palette const &TileSheetEditorModel::pal() const noexcept { if (m_pal) { return *m_pal; } diff --git a/src/nostalgia/modules/gfx/src/studio/tilesheeteditor/tilesheeteditorview.cpp b/src/nostalgia/modules/gfx/src/studio/tilesheeteditor/tilesheeteditorview.cpp index 6e555e65..1190db3a 100644 --- a/src/nostalgia/modules/gfx/src/studio/tilesheeteditor/tilesheeteditorview.cpp +++ b/src/nostalgia/modules/gfx/src/studio/tilesheeteditor/tilesheeteditorview.cpp @@ -89,7 +89,7 @@ void TileSheetEditorView::clickSelect(ox::Vec2 const&paneSize, ox::Vec2 const&cl void TileSheetEditorView::clickFill(ox::Vec2 const&paneSize, ox::Vec2 const&clickPos) noexcept { auto const pt = clickPoint(paneSize, clickPos); - m_model.fill(pt, static_cast(m_palIdx)); + m_model.fill(pt, static_cast(m_palIdx)); } void TileSheetEditorView::releaseMouseButton(TileSheetTool tool) noexcept {