From 3c804bf62ab9c24cad14339d844df1547834b027 Mon Sep 17 00:00:00 2001
From: Gary Talent <gary@drinkingtea.net>
Date: Mon, 3 Feb 2025 23:30:07 -0600
Subject: [PATCH] [studio] Give MakeCopy popup an error message for files that
 already exist

---
 .../studio/applib/src/makecopypopup.cpp       | 33 ++++++++++++-------
 .../studio/applib/src/makecopypopup.hpp       |  5 ++-
 src/olympic/studio/applib/src/studioapp.cpp   |  2 +-
 3 files changed, 27 insertions(+), 13 deletions(-)

diff --git a/src/olympic/studio/applib/src/makecopypopup.cpp b/src/olympic/studio/applib/src/makecopypopup.cpp
index db6c4f3b..3866a782 100644
--- a/src/olympic/studio/applib/src/makecopypopup.cpp
+++ b/src/olympic/studio/applib/src/makecopypopup.cpp
@@ -13,6 +13,7 @@ ox::Error MakeCopyPopup::open(ox::StringViewCR path) noexcept {
 	m_dirPath = substr(path, 0, idx + 1);
 	m_title = sfmt("Copy {}", path);
 	m_fileName = "";
+	m_errMsg = "";
 	return {};
 }
 
@@ -25,7 +26,7 @@ bool MakeCopyPopup::isOpen() const noexcept {
 	return m_open;
 }
 
-void MakeCopyPopup::draw(StudioContext const &ctx, ImVec2 const &sz) noexcept {
+void MakeCopyPopup::draw(StudioContext const &ctx) noexcept {
 	switch (m_stage) {
 		case Stage::Closed:
 			break;
@@ -36,25 +37,26 @@ void MakeCopyPopup::draw(StudioContext const &ctx, ImVec2 const &sz) noexcept {
 		[[fallthrough]];
 		case Stage::Open:
 			ig::centerNextWindow(ctx.tctx);
-			ImGui::SetNextWindowSize(sz);
-			constexpr auto modalFlags = ImGuiWindowFlags_NoCollapse | ImGuiWindowFlags_NoMove | ImGuiWindowFlags_NoResize;
+			ImGui::SetNextWindowSize({250, 0});
+			constexpr auto modalFlags =
+				ImGuiWindowFlags_NoCollapse |
+				ImGuiWindowFlags_NoMove |
+				ImGuiWindowFlags_NoResize;
 			if (ImGui::BeginPopupModal(m_title.c_str(), &m_open, modalFlags)) {
 				if (ImGui::IsWindowAppearing()) {
 					ImGui::SetKeyboardFocusHere();
 				}
 				ig::InputText("Name", m_fileName);
+				if (ImGui::IsItemFocused() && ImGui::IsKeyPressed(ImGuiKey_Enter)) {
+					accept(ctx);
+				}
+				ImGui::Text("%s", m_errMsg.c_str());
 				bool open = true;
 				switch (ig::PopupControlsOkCancel(open)) {
 					case ig::PopupResponse::None:
 						break;
 					case ig::PopupResponse::OK:
-						{
-							auto const p = sfmt("{}{}", m_dirPath, m_fileName);
-							if (!ctx.project->exists(p)) {
-								makeCopy.emit(m_srcPath, p);
-								close();
-							}
-						}
+						accept(ctx);
 						break;
 					case ig::PopupResponse::Cancel:
 						close();
@@ -66,5 +68,14 @@ void MakeCopyPopup::draw(StudioContext const &ctx, ImVec2 const &sz) noexcept {
 	}
 }
 
+void MakeCopyPopup::accept(StudioContext const &ctx) noexcept {
+	auto const p = sfmt("{}{}", m_dirPath, m_fileName);
+	if (!ctx.project->exists(p)) {
+		makeCopy.emit(m_srcPath, p);
+		close();
+	} else {
+		m_errMsg = sfmt("{} already exists", p);
+	}
+}
 
-}
\ No newline at end of file
+}
diff --git a/src/olympic/studio/applib/src/makecopypopup.hpp b/src/olympic/studio/applib/src/makecopypopup.hpp
index 10313506..18ce9684 100644
--- a/src/olympic/studio/applib/src/makecopypopup.hpp
+++ b/src/olympic/studio/applib/src/makecopypopup.hpp
@@ -20,6 +20,7 @@ class MakeCopyPopup {
 		};
 		Stage m_stage = Stage::Closed;
 		bool m_open{};
+		ox::String m_errMsg;
 		ox::String m_title{"Copy File"};
 		ox::String m_srcPath;
 		ox::String m_dirPath;
@@ -35,8 +36,10 @@ class MakeCopyPopup {
 		[[nodiscard]]
 		bool isOpen() const noexcept;
 
-		void draw(StudioContext const &ctx, ImVec2 const &sz = {}) noexcept;
+		void draw(StudioContext const &ctx) noexcept;
 
+	private:
+		void accept(StudioContext const &ctx) noexcept;
 };
 
 }
diff --git a/src/olympic/studio/applib/src/studioapp.cpp b/src/olympic/studio/applib/src/studioapp.cpp
index 37ef95d6..ea2b04bc 100644
--- a/src/olympic/studio/applib/src/studioapp.cpp
+++ b/src/olympic/studio/applib/src/studioapp.cpp
@@ -137,7 +137,7 @@ void StudioUI::draw() noexcept {
 			p->draw(m_sctx);
 		}
 		m_closeFileConfirm.draw(m_sctx);
-		m_copyFilePopup.draw(m_sctx, {250, 0});
+		m_copyFilePopup.draw(m_sctx);
 	}
 	ImGui::End();
 	handleKeyInput();