drinkingtea/nostalgia
drinkingtea/nostalgia
2
0
Fork 0
Code Issues 7 Pull Requests Actions Releases 9 Activity

[nostalgia/core,turbine] Give Turbine and NostalgiaCore Context types virtual destructors

Browse Source
This commit is contained in:
Gary Talent 2023-06-27 19:38:16 -05:00
parent de6308418e
commit 39eb82596b
3 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/nostalgia/modules/core/include/nostalgia/core/context.hpp
View File

@ -23,6 +23,7 @@ class Context {
Context(Context &other) noexcept = delete; Context(Context &other) noexcept = delete;
Context(const Context &other) noexcept = delete; Context(const Context &other) noexcept = delete;
Context(const Context &&other) noexcept = delete; Context(const Context &&other) noexcept = delete;
virtual ~Context() noexcept = default;
}; };

2
src/nostalgia/modules/core/src/opengl/context.hpp
View File

@ -26,7 +26,7 @@ struct GlContext: public core::Context {
ox::Optional<ox::Size> renderSize; ox::Optional<ox::Size> renderSize;
renderer::Drawer drawer; renderer::Drawer drawer;
explicit GlContext(turbine::Context &tctx) noexcept; explicit GlContext(turbine::Context &tctx) noexcept;
~GlContext() noexcept; ~GlContext() noexcept override;
}; };
} }

2
src/turbine/context.hpp
View File

@ -64,7 +64,7 @@ class Context {
Context(const Context &&other) noexcept = delete; Context(const Context &&other) noexcept = delete;
public: public:
inline ~Context() noexcept { virtual inline ~Context() noexcept {
shutdown(*this); shutdown(*this);
} }