drinkingtea/nostalgia
2
0
Fork 0
Code Issues 4 Pull Requests Actions Releases 13 Activity

[keel] Fix AssetRef to call incRef on initial creation of ref, not just copy
All checks were successful
Build / build (push) Successful in 1m18s
Details

Browse Source
This commit is contained in:
Gary Talent
2025-07-31 22:06:52 -05:00
parent 5476417be2
commit 31b39982c5
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/olympic/keel/include/keel/assetmanager.hpp
View File

@@ -64,11 +64,13 @@ class AssetContainer {
protected: protected:
constexpr void incRefs() const noexcept { constexpr void incRefs() const noexcept {
oxAssert(m_references < ox::MaxValue<decltype(m_references)>, "reference count exceeds maximum");
++m_references; ++m_references;
} }
constexpr void decRefs() const noexcept { constexpr void decRefs() const noexcept {
--m_references; --m_references;
oxAssert(m_references >= 0, "negative references");
} }
[[nodiscard]] [[nodiscard]]
@@ -162,6 +164,7 @@ template<typename T>
constexpr AssetRef<T>::AssetRef(AssetContainer<T> const*c) noexcept: m_ctr(c) { constexpr AssetRef<T>::AssetRef(AssetContainer<T> const*c) noexcept: m_ctr(c) {
if (m_ctr) { if (m_ctr) {
m_ctr->updated.connect(this, &AssetRef::emitUpdated); m_ctr->updated.connect(this, &AssetRef::emitUpdated);
m_ctr->incRefs();
} }
} }