From 110d4a2e6ab32daf74d256fd8ffff489dbc4a932 Mon Sep 17 00:00:00 2001
From: Gary Talent <gary@drinkingtea.net>
Date: Sat, 7 Feb 2026 15:29:53 -0600
Subject: [PATCH] [keel] Cleanup

---
 src/olympic/keel/include/keel/media.hpp    |  4 ----
 src/olympic/keel/include/keel/module.hpp   |  4 ++--
 src/olympic/keel/include/keel/typeconv.hpp | 22 +++++++++++++---------
 3 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/src/olympic/keel/include/keel/media.hpp b/src/olympic/keel/include/keel/media.hpp
index e53bcef5..7b07242b 100644
--- a/src/olympic/keel/include/keel/media.hpp
+++ b/src/olympic/keel/include/keel/media.hpp
@@ -189,8 +189,4 @@ ox::Error setRomFs(Context &ctx, ox::UPtr<ox::FileSystem> &&fs) noexcept;
 
 ox::Result<ox::UPtr<ox::FileSystem>> loadRomFs(ox::StringViewCR path) noexcept;
 
-ox::Result<char*> loadRom(ox::StringViewCR path = "") noexcept;
-
-void unloadRom(char*) noexcept;
-
 }
diff --git a/src/olympic/keel/include/keel/module.hpp b/src/olympic/keel/include/keel/module.hpp
index 0053e803..28519422 100644
--- a/src/olympic/keel/include/keel/module.hpp
+++ b/src/olympic/keel/include/keel/module.hpp
@@ -37,9 +37,9 @@ class Module {
 		virtual ox::Vector<PackTransform> packTransforms() const noexcept;
 };
 
-void registerModule(Module const*mod) noexcept;
+void registerModule(Module const *mod) noexcept;
 
 [[nodiscard]]
-ox::Vector<keel::Module const*> const &modules() noexcept;
+ox::Vector<Module const*> const &modules() noexcept;
 
 }
diff --git a/src/olympic/keel/include/keel/typeconv.hpp b/src/olympic/keel/include/keel/typeconv.hpp
index df3232fb..33282b4a 100644
--- a/src/olympic/keel/include/keel/typeconv.hpp
+++ b/src/olympic/keel/include/keel/typeconv.hpp
@@ -19,7 +19,7 @@ class Wrap {
 	public:
 		virtual ~Wrap() = default;
 		[[nodiscard]]
-		virtual ox::CStringView typeName() const noexcept = 0;
+		virtual ox::StringLiteral typeName() const noexcept = 0;
 		[[nodiscard]]
 		virtual int typeVersion() const noexcept = 0;
 		[[nodiscard]]
@@ -48,7 +48,7 @@ class WrapRef final: public WrapT<T> {
 		constexpr explicit WrapRef(T &obj): m_obj{obj} {}
 
 		[[nodiscard]]
-		ox::CStringView typeName() const noexcept override {
+		ox::StringLiteral typeName() const noexcept override {
 			return ox::ModelTypeName_v<T>;
 		}
 
@@ -77,7 +77,7 @@ class WrapInline final: public WrapT<T> {
 		}
 
 		[[nodiscard]]
-		ox::CStringView typeName() const noexcept override {
+		ox::StringLiteral typeName() const noexcept override {
 			return ox::ModelTypeName_v<T>;
 		}
 
@@ -108,7 +108,7 @@ class BaseConverter {
 		constexpr virtual ~BaseConverter() noexcept = default;
 
 		[[nodiscard]]
-		constexpr virtual ox::StringView srcTypeName() const noexcept = 0;
+		constexpr virtual ox::StringLiteral srcTypeName() const noexcept = 0;
 
 		[[nodiscard]]
 		constexpr virtual int srcTypeVersion() const noexcept = 0;
@@ -154,7 +154,7 @@ class ConverterFunc final: public BaseConverter {
 		using DstType = typename decltype(extractParams(Func))::Dst;
 
 		[[nodiscard]]
-		constexpr ox::StringView srcTypeName() const noexcept override {
+		constexpr ox::StringLiteral srcTypeName() const noexcept override {
 			return ox::ModelTypeName_v<SrcType>;
 		}
 
@@ -253,19 +253,22 @@ template<typename DstType>
 ox::Result<DstType> convertObjToObj(
 		Context &ctx,
 		auto &src) noexcept {
-	OX_REQUIRE_M(out, convert(ctx, WrapRef{src}, ox::ModelTypeName_v<DstType>, ox::ModelTypeVersion_v<DstType>));
+	OX_REQUIRE_M(out,
+		convert(ctx, WrapRef{src}, ox::ModelTypeName_v<DstType>, ox::ModelTypeVersion_v<DstType>));
 	return std::move(wrapCast(*out));
 }
 
 template<typename DstType>
 ox::Result<DstType> convert(Context &ctx, ox::BufferView const &src) noexcept {
-	OX_REQUIRE(out, convert(ctx, src, ox::ModelTypeName_v<DstType>, ox::ModelTypeVersion_v<DstType>));
+	OX_REQUIRE(out,
+		convert(ctx, src, ox::ModelTypeName_v<DstType>, ox::ModelTypeVersion_v<DstType>));
 	return std::move(wrapCast<DstType>(*out));
 }
 
 template<typename DstType>
 ox::Error convert(Context &ctx, ox::BufferView const &buff, DstType &outObj) noexcept {
-	OX_REQUIRE(out, convert(ctx, buff, ox::ModelTypeName_v<DstType>, ox::ModelTypeVersion_v<DstType>));
+	OX_REQUIRE(out,
+		convert(ctx, buff, ox::ModelTypeName_v<DstType>, ox::ModelTypeVersion_v<DstType>));
 	outObj = std::move(wrapCast<DstType>(*out));
 	return {};
 }
@@ -280,7 +283,8 @@ ox::Error convertObjToObj(Context &ctx, auto &src, DstType &outObj) noexcept {
 template<typename DstType>
 ox::Result<ox::Buffer> convertBuffToBuff(
 		Context &ctx, ox::BufferView const &src, ox::ClawFormat const fmt) noexcept {
-	OX_REQUIRE(out, convert(ctx, src, ox::ModelTypeName_v<DstType>, ox::ModelTypeVersion_v<DstType>));
+	OX_REQUIRE(out,
+		convert(ctx, src, ox::ModelTypeName_v<DstType>, ox::ModelTypeVersion_v<DstType>));
 	return ox::writeClaw<DstType>(wrapCast<DstType>(*out), fmt);
 }