drinkingtea/nostalgia
drinkingtea/nostalgia
2
0
Fork 0
Code Issues 6 Pull Requests Actions Releases 6 Activity

[ox/std] Shift away 4 lowest bits of random numbers generated in UUID,

Browse Source 
as Xoroshiro128+ is apparently weaker for those bits
This commit is contained in:
Gary Talent 2023-03-03 00:57:25 -06:00
parent b576a7ec12
commit 06f6656c85
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
deps/ox/src/ox/std/uuid.cpp vendored
View File

@ -25,7 +25,9 @@ Result<UUID> UUID::generate() noexcept {
} }
UUID out; UUID out;
for (auto &v : out.m_value) { for (auto &v : out.m_value) {
v = static_cast<uint8_t>(s_rand.gen() % 255); // shift away 4 lowest bits, as Xoroshiro128+ randomness is weaker there
const auto rand = s_rand.gen() >> 4;
v = static_cast<uint8_t>(rand % 255);
} }
out.m_value[6] &= 0x0f; out.m_value[6] &= 0x0f;
out.m_value[6] |= 4 << 4; out.m_value[6] |= 4 << 4;