From 04cb710d567da85d731e56c432c4b6fc79991a29 Mon Sep 17 00:00:00 2001 From: Gary Talent Date: Sat, 17 Jun 2023 20:03:45 -0500 Subject: [PATCH] [glutils,keel,nostalgia,turbine] Cleanup sign conversion warnings that are now enabled universal --- src/glutils/CMakeLists.txt | 4 ---- src/keel/CMakeLists.txt | 4 ---- src/nostalgia/modules/CMakeLists.txt | 4 +--- src/nostalgia/modules/core/src/studio/CMakeLists.txt | 5 ----- src/nostalgia/modules/scene/src/studio/CMakeLists.txt | 4 ---- src/turbine/CMakeLists.txt | 4 ---- 6 files changed, 1 insertion(+), 24 deletions(-) diff --git a/src/glutils/CMakeLists.txt b/src/glutils/CMakeLists.txt index 3b6a1055..1b282a55 100644 --- a/src/glutils/CMakeLists.txt +++ b/src/glutils/CMakeLists.txt @@ -3,10 +3,6 @@ add_library( glutils.cpp ) -if(NOT MSVC) - target_compile_options(GlUtils PRIVATE -Wsign-conversion) -endif() - target_link_libraries( GlUtils PUBLIC OxStd diff --git a/src/keel/CMakeLists.txt b/src/keel/CMakeLists.txt index 67c55c7a..4b8ae9b3 100644 --- a/src/keel/CMakeLists.txt +++ b/src/keel/CMakeLists.txt @@ -9,10 +9,6 @@ add_library( typestore.cpp ) -if(NOT MSVC) - target_compile_options(Keel PRIVATE -Wsign-conversion) -endif() - target_link_libraries( Keel PUBLIC OxClaw diff --git a/src/nostalgia/modules/CMakeLists.txt b/src/nostalgia/modules/CMakeLists.txt index 67f85354..d2da407c 100644 --- a/src/nostalgia/modules/CMakeLists.txt +++ b/src/nostalgia/modules/CMakeLists.txt @@ -16,9 +16,7 @@ target_link_libraries( NostalgiaCore-Keel NostalgiaScene-Keel ) -if(NOT MSVC) - target_compile_options(NostalgiaKeelModules PRIVATE -Wsign-conversion) -endif() + install( FILES keelmodules.hpp diff --git a/src/nostalgia/modules/core/src/studio/CMakeLists.txt b/src/nostalgia/modules/core/src/studio/CMakeLists.txt index aa010144..e620b732 100644 --- a/src/nostalgia/modules/core/src/studio/CMakeLists.txt +++ b/src/nostalgia/modules/core/src/studio/CMakeLists.txt @@ -14,11 +14,6 @@ add_library( tilesheeteditor-imgui.cpp ) -if(NOT MSVC) - target_compile_options(NostalgiaCore-Studio PRIVATE -Wsign-conversion) - target_compile_options(NostalgiaCore-Studio-ImGui PRIVATE -Wsign-conversion) -endif() - target_link_libraries( NostalgiaCore-Studio PUBLIC NostalgiaCore diff --git a/src/nostalgia/modules/scene/src/studio/CMakeLists.txt b/src/nostalgia/modules/scene/src/studio/CMakeLists.txt index c3df0280..4c45aa2a 100644 --- a/src/nostalgia/modules/scene/src/studio/CMakeLists.txt +++ b/src/nostalgia/modules/scene/src/studio/CMakeLists.txt @@ -6,10 +6,6 @@ add_library( sceneeditorview.cpp ) -if(NOT MSVC) - target_compile_options(NostalgiaScene-Studio PRIVATE -Wsign-conversion) -endif() - target_link_libraries( NostalgiaScene-Studio PUBLIC NostalgiaScene diff --git a/src/turbine/CMakeLists.txt b/src/turbine/CMakeLists.txt index 698a2931..47cd4f16 100644 --- a/src/turbine/CMakeLists.txt +++ b/src/turbine/CMakeLists.txt @@ -9,10 +9,6 @@ else() add_subdirectory(glfw) endif() -if(NOT MSVC) - target_compile_options(Turbine PRIVATE -Wsign-conversion) -endif() - target_link_libraries( Turbine PUBLIC Keel