drinkingtea/jasper
2
0
Fork 0
Code Issues 2 Pull Requests Actions Releases Activity

[jasper/world] Make palBank fields 8 bit
All checks were successful
Build / build (push) Successful in 3m48s
Details

Browse Source
This commit is contained in:
Gary Talent
2025-01-14 00:11:32 -06:00
parent 68e2d390ba
commit 9187c07551
6 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/jasper/modules/world/src/studio/worldobjectseteditor/commands/rmpalette.cpp
View File

@@ -15,8 +15,8 @@ RmPalette::RmPalette(WorldObjectSet &doc, size_t const rmIdx) noexcept:
m_objUpdates.reserve(m_doc.objects.size());
for (size_t i = 0; auto const&obj : m_doc.objects) {
if (obj.palBank >= m_rmIdx) {
auto const newPalBank = static_cast<uint16_t>(obj.palBank == m_rmIdx ?
0 : obj.palBank - 1);
uint8_t const newPalBank = obj.palBank == m_rmIdx ?
0 : obj.palBank - 1;
m_objUpdates.emplace_back(ObjUpdate{
.idx = i,
.oldPalBank = obj.palBank,

4
src/jasper/modules/world/src/studio/worldobjectseteditor/commands/rmpalette.hpp
View File

@@ -19,8 +19,8 @@ class RmPalette: public studio::UndoCommand {
size_t const m_rmIdx = 0;
struct ObjUpdate {
size_t idx{};
uint16_t oldPalBank{};
uint16_t newPalBank{};
uint8_t oldPalBank{};
uint8_t newPalBank{};
};
ox::Vector<ObjUpdate> m_objUpdates;
public:

2
src/jasper/modules/world/src/studio/worldobjectseteditor/worldobjectseteditor-imgui.cpp
View File

@@ -183,7 +183,7 @@ void WorldObjectSetEditorImGui::drawObjEditor() noexcept {
ig::IDStackItem const subsheetSelectorStackItem("SubsheetSelector");
if (ig::ComboBox("Palette", m_paletteDisplayNames, m_objEditor.palette)) {
std::ignore = pushCommand<EditObjectPalette>(
m_doc, m_selectedObj, static_cast<uint16_t>(m_objEditor.palette));
m_doc, m_selectedObj, static_cast<uint8_t>(m_objEditor.palette));
}
if (ImGui::InputInt("Frames", &m_objEditor.frames, 1)) {
m_objEditor.frames = ox::max(m_objEditor.frames, 1);